It can be debated in modern times as of whether he was a good leader or a bad leader, but is there any sources of how he was viewed in ancient times as a leader?
Perhaps remarkably, we have no ancient testimony on this point. The text that deals most closely with Odysseus' leadership qualities is none other than the Odyssey itself. There, the main thrust of the depiction of Odysseus as a leader is conveyed in the proem:
...he suffered many pains on the sea in his heart,
striving for his own life and his companions' return,
but even so he did not save his companions, much though he wanted:
for they died through their own follies,
idiots, who consumed the cattle of Hyperion the Sun:
then he took away their day of homecoming.
And Od. 5.108-111:
...but in their return they offended Athene,
and she roused a destructive wind and tall waves,
and then all the other good companions perished,
but the wind and the wave brought him here...
The proem fairly firmly assigns responsibility for their deaths to the companions themselves. The second passage is less explicit. That seems to be standard fare throughout the epic: the narrator isn't quite sure who, if anyone, is responsible for the deaths of every single one of Odysseus' companions.
The relevant secondary literature is Stanford's The Ulysses Theme (1954), chapter 5; and Haubold's Homer's People (2000) especially pp. 100-109. But neither of them addresses this specific question.
The plain fact is that we don't have any ancient views on this question (unless I'm missing something, of course). Odysseus had a mixed reception at the best of times. In the Odyssey itself he's an ideal proto-colonist, exploring the world and overcoming the obstacles that lie in the way of exploration and colonisation. In later literary depictions of him he's more ambiguous: at times he's a diplomat (Sophokles' Aias), at others a ruthless utilitarian (Sophokles' Philoktetes). Both of these interpretations are prefigured within Homer, though less explicitly. But his leadership qualities never seem to come under scrutiny. If you think that's weird, I won't disagree. However, the upshot is that the answer to your question seems to be "no": there aren't any sources that discuss his leadership. Even the satirical depiction in Lucian's True Histories focuses on his philandering, not his talent for losing his men.