Recently I've picked up some of the Flashman books, and have fallen in love with his frank, albeit brutish and bigoted, analysis of Victorian colonial history... Are there any Flashman fans among the historians here, and if so, are there major errors in George Macdonald Fraser's writing? If this question is better suited for r/askhistory I'll post it there.
I'm a big fan of the Flashman Papers, and as far as I've been able to determine, they are very well-researched and accurate, though of course events and especially characters are filtered through MacDonald's own interpretation as well as Harry Flashman's.
In addition, some aspects of the books are outright fictional. For example, Royal Flash is based on the 1894 novel Prisoner of Zenda and is set in a purely fictional location. The inspiration for this novel, aside from MacDonald's knowledge of the Prisoner of Zenda, was his discovery during research that Bismarck and Lola Montez had been in London at the same time.