This question has been posed several times before. While there's always more to say, you might find these discussions helpful:

How did medieval knights stay fit for combat?

How did the Greek hoplites work out?