I'm aware donating blood regularly can be good for you. However the health benefits of donating blood are seen long term and would be (I assume) very difficult to see/prove with the level on medical knowledge available at the time bloodletting was a thing.
Also, people with high blood pressure can get an immediate (tho short) lessening of symptoms from loosing some blood. But chronic stress, obesity, and metabolic syndrome were hardly prevalent conditions back then to render bloodletting useful for that purpose.
So... what gives?
I answered this question a while back. I also produced a two-part podcast series in partnership with the American College of Physicians on how debates and bloodletting essentially led to modern medicine: Let It Bleed and Blood on the Tracks.
But a view key points:
Let me know if you have any questions.