Grew up in another European country and I can't say we studied properly British history in school, so I'm not quite familiar with everything he did, besides his participation in WW2. However, I find a lot of controversial opinions regarding him. Was he considered a good PM at the time or not? Has the opinion of the British people changed since?
Churchill is beloved as the wartime prime minister that provided strong, unflinching leadership to the UK at its lowest point of recent memory. He did this a number of ways:
The views on some of these points, particularly #2, have changed over the years. At a time when everybody was still reeling from WW1 his call to arms against Hitler was initially not well received. As is often the case, with the benefit of hindsight this has been seen as one of his positives.
Churchill is often bemoaned for some of the following issues:
Basically he was stubborn, self-confident, and a bigot. His steadfastness in WW2 combined with his masterful oration allowed him to become bigger than life. When juxtaposed with the changes that were taking place all around him, he was a figure unwilling to change or adjust.
His racial views are particularly damning. We must remember he was born into a society and social class who most likely all held these views, but still he was rather outspoken about it and didn't refrain from letting his personal views go public which doesn't bode well for a national leader.
We owe him a great debt of gratitude for being a lynchpin in defeating Nazism. He was the only person capable at the time of stepping in and leading that charge, but mostly everything he touched before and after WW2 is marred in controversy, ineffectiveness, and out dated conservative imperialism.